Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust port conflict message if using clusterset IP #1644

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

tpantelis
Copy link
Contributor

State that it will expose the union of the service ports instead of the intersection.

@tpantelis tpantelis self-assigned this Sep 23, 2024
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1644/tpantelis/port_conflict
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

State that it will expose the union of the service ports instead of
the intersection.

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis force-pushed the port_conflict branch 2 times, most recently from f9acead to 078f986 Compare September 24, 2024 18:45
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Sep 25, 2024
@tpantelis tpantelis merged commit 3989a7b into submariner-io:devel Sep 25, 2024
26 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1644/tpantelis/port_conflict]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants