Implement clusterset IP in the CoredDNS plugin #1641
Conversation
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1641/tpantelis/clusterset_vip_plugin |
tpantelis
force-pushed
the
clusterset_vip_plugin
branch
from
d3016f3
to
2a727e3
Compare
Modify the resolver to return the ServiceImport's IP if it's set and a specific cluster name wasn't requested. If the latter then return the cluster's DNS record info as it normally does. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
clusterset_vip_plugin
branch
from
2a727e3
to
6bac66a
Compare
| @@ -88,3 +88,7 @@ func (si *serviceInfo) selectIP(checkCluster func(string) bool) *DNSRecord { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (si *serviceInfo) isHeadless() bool { | |||
There was a problem hiding this comment.
QQ: I know it's a small function, but performance-wise - isn't it better to keep the current code ? I mean calculate it once when serviceInfo is created and not every time DNS resolver is called.
There was a problem hiding this comment.
I made it a method for readability and to avoid duplicate storage. It might be a little faster as a variable but the difference would be extremely negligible (probably in nanosec). Plus compilers are pretty smart about optimizing and caching frequently accessed code.
|
🤖 Closed branches: [z_pr1641/tpantelis/clusterset_vip_plugin] |
Modify the resolver to return the
ServiceImport's IP if it's set and a specific cluster name wasn't requested. If the latter then return the cluster's DNS record info as it normally does.