Address golangci-lint v1.60.3 errors #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
aswinsuryan,
dfarrell07,
maayanf24,
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr1631/tpantelis/v1.60.3_linting |
tpantelis
force-pushed
the
v1.60.3_linting
branch
from
9a33582
to
678bc3f
Compare
skitt
requested changes
Aug 28, 2024
yeah as it turned out. I had thought it would be affected by the Shipyard E2E changes but it wasn't. Still it doesn't hurt to bump it but I'll remove it. |
tpantelis
force-pushed
the
v1.60.3_linting
branch
from
678bc3f
to
87e23ab
Compare
tpantelis
changed the title
Specifically, gosec "integer overflow conversion" issues. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
v1.60.3_linting
branch
from
87e23ab
to
1a19d62
Compare
|
This PR/issue depends on: |
dfarrell07
approved these changes
Aug 28, 2024
skitt
approved these changes
Aug 29, 2024
|
🤖 Closed branches: [z_pr1631/tpantelis/v1.60.3_linting] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, gosec "integer overflow conversion" issues.
Depends on submariner-io/shipyard#1715