Fix sporadic failure in resolver migration unit test #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The round-robin test may not see cluster1's IP yet which causes it to fail, instead just wait until the resolver eventually returns the IP. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1622/tpantelis/fix_resolver_ut |
vthapar
approved these changes
Aug 21, 2024
skitt
approved these changes
Aug 21, 2024
|
🤖 Closed branches: [z_pr1622/tpantelis/fix_resolver_ut] |
|
@tpantelis thinks this was related to a version bump that may not have happened on other branches. Not sure if we need to backport, will keep an eye out for the failure on other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The round-robin test may not see cluster1's IP yet which causes it to fail, instead just wait until the resolver eventually returns the IP.