Requeue ServiceExport when the global IP becomes available #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...rather than continuously re-queueing/retrying when it isn't available yet. This reduces the amount of re-queueing which can accumulate significant delays over time at scale due to the queue's bucket rate limiter. The globalIngressIPCache was adjusted to take a callback to be notified when the associated GlobalIngressIP is created or updated. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1551/tpantelis/optimize_gn_cache |
dfarrell07
approved these changes
Apr 30, 2024
|
🤖 Closed branches: [z_pr1551/tpantelis/optimize_gn_cache] |
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
May 7, 2024
Release notes for submariner-io/lighthouse#1551 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
May 8, 2024
Release notes for submariner-io/lighthouse#1551 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Jul 8, 2024
Release notes for submariner-io/lighthouse#1551 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Jul 9, 2024
Release notes for submariner-io/lighthouse#1551 Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rather than continuously re-queueing/retrying when it isn't available yet. This reduces the amount of re-queueing which can accumulate significant delays over time at scale due to the queue's bucket rate limiter. The
globalIngressIPCachewas adjusted to take a callback to be notified when the associatedGlobalIngressIPis created or updated.