Delete stale EndpointSlices on restart #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1430/tpantelis/stale_eps |
aswinsuryan
approved these changes
Nov 1, 2023
vthapar
approved these changes
Nov 2, 2023
sridhargaddam
requested changes
Nov 2, 2023
| logger.Infof("The service %q for EndpointSlice \"%s/%s\" does not exist - deleting it", | ||
| serviceName, endpointSlice.Namespace, endpointSlice.Name) | ||
|
|
||
| err := c.syncer.GetLocalFederator().Delete(ctx, endpointSlice) |
There was a problem hiding this comment.
I hope this deletes the EndpointSlice from the Broker as well?
There was a problem hiding this comment.
yup - the admiral syncer does that.
| test.CreateResource(t.cluster1.localServiceExportClient, serviceExport) | ||
| t.cluster1.createService() | ||
|
|
||
| fmt.Println("*******EPS 1: ", resource.ToJSON(localEndpointSlice)) |
There was a problem hiding this comment.
Suggested change
| fmt.Println("*******EPS 1: ", resource.ToJSON(localEndpointSlice)) |
If a local LH EndpointSlices exists but the corresponding Service doesn't exist, delete the EPS. Also, a headless Service can have multiple EndpointSlices so reconcile the LH EndpointSlices on startup to handle a K8s EndpointSlice deleted while the controller wasn't running. Fixes submariner-io#1416 Signed-off-by: Tom Pantelis <[email protected]>
sridhargaddam
approved these changes
Nov 2, 2023
|
🤖 Closed branches: [z_pr1430/tpantelis/stale_eps] |
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 2, 2023
Release notes for submariner-io/lighthouse#1430 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 2, 2023
Release notes for submariner-io/lighthouse#1430 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Nov 2, 2023
Release notes for submariner-io/lighthouse#1430 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Nov 3, 2023
Release notes for submariner-io/lighthouse#1430 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to tpantelis/submariner-website
that referenced
this pull request
Feb 27, 2024
Release notes for submariner-io/lighthouse#1430 Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
added a commit
to submariner-io/submariner-website
that referenced
this pull request
Feb 29, 2024
Release notes for submariner-io/lighthouse#1430 Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a local LH
EndpointSlicesexists but the correspondingServicedoesn't exist, delete theEndpointSlice.Also, a headless
Servicecan have multipleEndpointSlicesso reconcile the LHEndpointSliceson startup to handle a K8sEndpointSlicedeleted while the controller wasn't running.Fixes #1416