Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive exported EndpointSlices from K8s EndpointSlices instead of Endpoints #1318

Merged
merged 6 commits into from
Jul 26, 2023
Merged

Derive exported EndpointSlices from K8s EndpointSlices instead of Endpoints #1318

merged 6 commits into from
Jul 26, 2023

Commits on Jul 17, 2023

  1. Rename endpoint.go to service_endpoint_slices.go 

    Signed-off-by: Tom Pantelis <[email protected]>
    @tpantelis
    tpantelis committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d488771 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Bump admiral version and adjust to changes 

    Signed-off-by: Tom Pantelis <[email protected]>
    @tpantelis
    tpantelis committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    1508893 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Derive exported EndpointSlices from K8s EndpointSlices 

    ...instead of the service Endpoints.

For headless services, we simply mirror each K8s EndpointSlice,
substituting Globalnet IPs if enabled.

For cluster IP services, we still create a single EndpointSlice
containing the service IP's endpoint address. The ready condition
is detetermined by listing all the EndpointSlices and checking if any
endpoint condition is ready.

Signed-off-by: Tom Pantelis <[email protected]>
    @tpantelis
    tpantelis committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    ab1ce0d View commit details
    Browse the repository at this point in the history

  2. Delete legacy EndpointSlices derived from Endpoints 

    Signed-off-by: Tom Pantelis <[email protected]>
    @tpantelis
    tpantelis committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    26aaf12 View commit details
    Browse the repository at this point in the history

  3. Change PutEndpointSlice signature to PutEndpointSlices 

    ...to handle multiple headless EndpointSlices.

Signed-off-by: Tom Pantelis <[email protected]>
    @tpantelis
    tpantelis committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1058cb5 View commit details
    Browse the repository at this point in the history

  4. Handle multiple EndpointSlices in the resolver 

    For headless services, the controller retrieves all the EndpointSlices and,
on add/update, passes them to PutEndpointSlices. On delete, i there's no
more PutEndpointSlices, it calls RemoveEndpointSlice, otherwise
PutEndpointSlices.

Signed-off-by: Tom Pantelis <[email protected]>
    @tpantelis
    tpantelis committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c9f8741 View commit details
    Browse the repository at this point in the history