Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service discovery returning IPs of stale endpoints #1416

Closed
tpantelis opened this issue Oct 31, 2023 · 0 comments · Fixed by #1430
Closed

Service discovery returning IPs of stale endpoints #1416

tpantelis opened this issue Oct 31, 2023 · 0 comments · Fixed by #1430
Assignees
Labels
bug Something isn't working priority:high

Comments

@tpantelis
Copy link
Contributor

Related to https://issues.redhat.com/browse/ACM-8423.

The LH EndpointSlice still remained after a service was deleted. It seems the service was deleted while the LH agent wasn't running. We need to delete stale EndpointSlices on restart.

@tpantelis tpantelis added the bug Something isn't working label Oct 31, 2023
@tpantelis tpantelis self-assigned this Oct 31, 2023
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Nov 1, 2023
If a local LH EndpointSlices exists but the corresponding Service doesn't
exist, delete the EPS.

Also, a headless Service can have multiple EndpointSlices so reconcile
the LH EndpointSlices on startup to handle a K8s EndpointSlice deleted
while the controller wasn't running.

Fixes submariner-io#1416

Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Nov 2, 2023
If a local LH EndpointSlices exists but the corresponding Service doesn't
exist, delete the EPS.

Also, a headless Service can have multiple EndpointSlices so reconcile
the LH EndpointSlices on startup to handle a K8s EndpointSlice deleted
while the controller wasn't running.

Fixes submariner-io#1416

Signed-off-by: Tom Pantelis <[email protected]>
sridhargaddam pushed a commit that referenced this issue Nov 2, 2023
If a local LH EndpointSlices exists but the corresponding Service doesn't
exist, delete the EPS.

Also, a headless Service can have multiple EndpointSlices so reconcile
the LH EndpointSlices on startup to handle a K8s EndpointSlice deleted
while the controller wasn't running.

Fixes #1416

Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit to tpantelis/lighthouse that referenced this issue Nov 2, 2023
If a local LH EndpointSlices exists but the corresponding Service doesn't
exist, delete the EPS.

Also, a headless Service can have multiple EndpointSlices so reconcile
the LH EndpointSlices on startup to handle a K8s EndpointSlice deleted
while the controller wasn't running.

Fixes submariner-io#1416

Signed-off-by: Tom Pantelis <[email protected]>
tpantelis added a commit that referenced this issue Nov 2, 2023
If a local LH EndpointSlices exists but the corresponding Service doesn't
exist, delete the EPS.

Also, a headless Service can have multiple EndpointSlices so reconcile
the LH EndpointSlices on startup to handle a K8s EndpointSlice deleted
while the controller wasn't running.

Fixes #1416

Signed-off-by: Tom Pantelis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant