Trim ManagedFields in the resource syncer to

...reduce the informer cache memory usage. Fixes #859 Signed-off-by: Tom Pantelis <[email protected]>
submariner-io · Apr 3, 2024 · c2aff77 · c2aff77
1 parent 8bea092
commit c2aff77
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/pkg/syncer/resource_syncer.go b/pkg/syncer/resource_syncer.go
@@ -241,7 +241,7 @@ func NewResourceSyncer(config *ResourceSyncerConfig) (Interface, error) {
 
 	resourceClient := config.SourceClient.Resource(*gvr).Namespace(config.SourceNamespace)
 
-	syncer.store, syncer.informer = cache.NewInformer(&cache.ListWatch{
+	syncer.store, syncer.informer = cache.NewTransformingInformer(&cache.ListWatch{
 		ListFunc: func(options metav1.ListOptions) (runtime.Object, error) {
 			options.LabelSelector = config.SourceLabelSelector
 			options.FieldSelector = config.SourceFieldSelector
@@ -256,6 +256,9 @@ func NewResourceSyncer(config *ResourceSyncerConfig) (Interface, error) {
 		AddFunc:    syncer.onCreate,
 		UpdateFunc: syncer.onUpdate,
 		DeleteFunc: syncer.onDelete,
+	}, func(obj interface{}) (interface{}, error) {
+		resourceUtil.MustToMeta(obj).SetManagedFields(nil)
+		return obj, nil
 	})
 
 	return syncer, nil

diff --git a/test/e2e/watcher/watcher.go b/test/e2e/watcher/watcher.go
@@ -36,6 +36,7 @@ var _ = Describe("[watcher] Resource watcher tests", func() {
 		It("should notify the handler of each event", func() {
 			clusterName := framework.TestContext.ClusterIDs[framework.ClusterA]
 			toaster := util.CreateToaster(t.client, util.NewToaster("test-toaster", t.framework.Namespace), clusterName)
+			toaster.SetManagedFields(nil)
 			Eventually(t.created).Should(Receive(Equal(toaster)))
 
 			util.DeleteToaster(t.client, toaster, clusterName)