dev: Add Rubocop for linting #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-stytch
force-pushed
the
jeremy-lint
branch
4 times, most recently
from
50e1e37
to
4b79261
Compare
grace-stytch
approved these changes
Sep 11, 2023
jeremy-stytch
force-pushed
the
jeremy-lint
branch
from
4b79261
to
7725647
Compare
jeremy-stytch
added a commit
that referenced
this pull request
Sep 15, 2023
In #94, I chose to disable some Rubocop groups because they weren't related to code correctness. But this library does already conform to most of Rubocop's default Layout and Style rules, so we can re-enable them to keep that consistent.
jeremy-stytch
added a commit
that referenced
this pull request
Sep 15, 2023
In #94, I chose to disable some Rubocop groups because they weren't related to code correctness. But this library does already conform to most of Rubocop's default Layout and Style rules, so we can re-enable them to keep that consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a required Rubocop step to the Ruby workflow.
Rubocop accepts a configuration option for the target Ruby version, which, in our case, defaults to the lowest version number in
stytch.gemspec.For now, I think we should run Rubocop just once on that minimum/target Ruby version. But if we have a reason to run it as part of the test matrix, I think that would be fine too.
Testing
bundle(see thatrubocopandrubocop-rspecgot installed)bundle exec rubocop(should report no errors)I also put up a PR with an intentional linter error in #95 as an example.