Fix M2M authentication and add clock tolerance to JWT methods #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-stytch
force-pushed
the
jmccleary/m2m
branch
from
28afa3a
to
a7d901a
Compare
logan-stytch
approved these changes
Jul 24, 2024
lib/stytch/b2b_sessions.rb
Outdated
| include Stytch::RequestHelper | ||
|
|
||
| def initialize(connection, project_id, policy_cache) | ||
| def initialize(connection, project_id, is_b2b_client, policy_cache) |
There was a problem hiding this comment.
This feels slightly weird to me since the is_b2b_client param is unused (I think we could've been smarter about deciding whether a given class wants this param and limited to "hybrid" classes like M2M), but it's not hurting anything, so I think it's fine.
There was a problem hiding this comment.
Fixed in e1fb37b
logan-stytch
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
headerstoget_requestand specifying whether to use the B2B or B2C JWKS endpointclock_tolerance_secondsas an optional parameter toauthenticate_jwt,authenticate_jwt_localin the B2B and B2C sessions clients, and toauthenticate_tokenandauthenticate_token_localfor M2M. This is used as thenbf_leewayvalue to JWT verification to help with clock drift issues.