🐛 can handle invalid last_page in range function

src/helper.test.ts

@@ -1,4 +1,4 @@
-import { add, buildQueryParams, convertDateToWCTDate } from './helper';
+import { add, buildQueryParams, convertDateToWCTDate, range } from './helper';
 
 describe('The wecantrack API helper', () => {
   describe('The datetime converter', () => {
@@ -36,4 +36,21 @@ describe('The wecantrack API helper', () => {
       expect(result).toBe('b');
     });
   });
+
+  describe('Array range should return an array with number in given range', () => {
+    it('should return simple range from 1 to 5', () => {
+      const result = range(1, 5);
+      expect(result).toEqual([1, 2, 3, 4, 5]);
+    });
+
+    it('should handle 1 page result', () => {
+      const result = range(2, 1);
+      expect(result).toEqual([]);
+    });
+
+    it('can handle undefined', () => {
+      const result = range(2, undefined);
+      expect(result).toEqual([]);
+    });
+  });
 });

src/helper.ts

@@ -39,3 +39,10 @@ export function convertDateToWCTDate(date: Date): WCTDate {
 export function add(element: string, to: string): string {
   return to ? `${to},${element}` : element;
 }
+
+export const range = (start: number, end: number): number[] => {
+  if (!end) return [];
+  return Array(end - start + 1)
+    .fill(0)
+    .map((_, idx) => start + idx);
+};

src/utils.ts

@@ -1,6 +1,6 @@
 import fetch from 'node-fetch';
 import { BASE_URL, Endpoint } from './config';
-import { buildQueryParams } from './helper';
+import { buildQueryParams, range } from './helper';
 import { error } from './logger';
 import { GeneralResponseData } from './types';
 
@@ -77,12 +77,6 @@ export async function getAllPages<T extends GeneralResponseData>(
   }
 }
 
-const range = (start: number, end: number): number[] => {
-  return Array(end - start + 1)
-    .fill(0)
-    .map((_, idx) => start + idx);
-};
-
 const isPageRequest = (request: object): boolean => {
   return Object.keys(request).includes('page');
 };