Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose the CodeBuild CW Log retention period #125

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

major0
Copy link
Contributor

@major0 major0 commented Nov 28, 2023

Make the CloudWatch log retention period for the Code Build logs tunable.

@major0 major0 changed the title feat: Expose the CodeBuild CW Log retention period feat: expose the CodeBuild CW Log retention period Nov 28, 2023
Copy link
Member

@moritzzimmer moritzzimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@major0 thx for the PR, I just made some naming suggestions to keep the variables consistent.

modules/deployment/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
modules/deployment/variables.tf Outdated Show resolved Hide resolved
@moritzzimmer moritzzimmer self-assigned this Jan 8, 2024
@moritzzimmer moritzzimmer added the enhancement New feature or request label Jan 8, 2024
@moritzzimmer moritzzimmer merged commit 04cb4c1 into stroeer:main Jan 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants