Moved raw_request functions from stripe module to StripeClient class #1390
+153
−337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit__.py to StripeClient in _stripe_client.py updated tests and README
jar-stripe
commented
Sep 6, 2024
…lize method in lieu of values passed into client constructor
…nt-only' into jar/rawrequest-client-only
ramya-stripe
reviewed
Sep 6, 2024
ramya-stripe
reviewed
Sep 9, 2024
stripe/_stripe_client.py
Outdated
|
|
||
| from stripe._raw_request import raw_request as _raw_request # noqa | ||
| from stripe._raw_request import raw_request_async as _raw_request_async # noqa | ||
| from stripe._raw_request import deserialize as _deserialize # noqa |
There was a problem hiding this comment.
The above 3 methods use the global api requestor. I believe one of the key differentiators of the StripeClient model is that there is a dedicated api requestor per StripeClient that gets used instead of the global one - that is how we get to set different api-key/account per StripeClient.
Therefore, I think we need a bigger refactor.
There was a problem hiding this comment.
I think this is done. I removed _raw_request.py and merged those methods directly into StripeClient so I could use its _requestor member, and updated the tests to match.
… to use its _requestor updated test_raw_request to use stripe_client fixture updated test_integration to use MOCK_API_KEY when creating StripeClient objects comments
…Y to match other tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We are changing our SDKs to move "raw request" functions into the
StripeClientclass.