Embedded confirm tests #4249
Merged
Embedded confirm tests #4249
+268
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooj-stripe
reviewed
Nov 13, 2024
Comment on lines
559
to
560
| XCTAssertTrue(app.buttons["Checkout"].isEnabled) | ||
| app.buttons["Checkout"].waitForExistenceAndTap() |
There was a problem hiding this comment.
Nit: probably should:
- wait for existence
- check if isEnabled
- tap
(seems to be copied to multiple tests)
Comment on lines
689
to
690
| let payButton = app.buttons["Confirm"] | ||
| payButton.waitForExistenceAndTap() |
There was a problem hiding this comment.
nit:
app.buttons["Confirm"].waitForExistenceAndTap()
Comment on lines
721
to
722
| let successText = app.staticTexts["Success!"] | ||
| XCTAssertTrue(successText.waitForExistence(timeout: 10.0)) |
There was a problem hiding this comment.
nit:
XCTAssertTrue(app.staticTexts["Success!"].waitForExistence(timeout: 10.0))
wooj-stripe
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Testing
Changelog
N/A