Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare STPPaymentConfiguration shared property with let to prevent swift concurrency issue #3604

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rbenna
Copy link

@rbenna rbenna commented May 24, 2024

Summary

Declare STPPaymentConfiguration shared property with let to prevent swift concurrency error when enabling complete mode for strict concurrency checking in the project that uses this library.

Motivation

Here's the error raised by the compiler on the declaration side @objc(sharedConfiguration) public static var shared = STPPaymentConfiguration():

Class property 'shared' is not concurrency-safe because it is non-isolated global shared mutable state; this is an error in Swift 6.

and here's the error on the use side of STPPaymentConfiguration.shared:

Reference to class property 'shared' is not concurrency-safe because it involves shared mutable state; this is an error in Swift 6

Unfortunately, import Stripe using @preconcurrency import doesn't fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant