Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporting chart beta component #159

Merged

Conversation

neerajsamtani-stripe
Copy link

@neerajsamtani-stripe neerajsamtani-stripe commented Sep 18, 2024

types/shared.d.ts Show resolved Hide resolved
Copy link
Contributor

@jorgea-stripe jorgea-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please don't merge until the component is ready! I don't have another way of removing the "waiting for changes"

Copy link
Contributor

@torrance-stripe torrance-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still LGTM to me!

@neerajsamtani-stripe neerajsamtani-stripe merged commit 154918b into preview Oct 3, 2024
1 check passed
@neerajsamtani-stripe neerajsamtani-stripe deleted the neerajsamtani-add-reporting-chart-component branch October 3, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants