This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #90, Adding gridfs support.
Sorry i'm not a ruby dev so maybe there's some better way to handle this.
I found Sequel couldn't properly use encode_bytea (which is what was needed to get around encoding issues mentioned in the issue ticket), so added in pg as a requirement for that, if you'd like to reduce dependencies you should find how to get Sequel to offer encode_bytea as a class method, I could only get it to work as an instance method by passing the pg object down
Also didn't have time to write tests (aside from finally successfully loading my gridfs store, which houses pdfs/ word docs/ images/ plaintext/etc) also i'm not overly used to ruby's test's.
I did /run/ the current tests and all but one passed (for $timestamp, but it was failing on master also so i'm gonna say not caused by this)