Skip to content
This repository has been archived by the owner on Dec 22, 2020. It is now read-only.

GridFS support #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

GridFS support #94

wants to merge 2 commits into from

Conversation

apocolipse
Copy link

This is for #90, Adding gridfs support.

Sorry i'm not a ruby dev so maybe there's some better way to handle this.
I found Sequel couldn't properly use encode_bytea (which is what was needed to get around encoding issues mentioned in the issue ticket), so added in pg as a requirement for that, if you'd like to reduce dependencies you should find how to get Sequel to offer encode_bytea as a class method, I could only get it to work as an instance method by passing the pg object down

Also didn't have time to write tests (aside from finally successfully loading my gridfs store, which houses pdfs/ word docs/ images/ plaintext/etc) also i'm not overly used to ruby's test's.
I did /run/ the current tests and all but one passed (for $timestamp, but it was failing on master also so i'm gonna say not caused by this)

@apocolipse apocolipse changed the title Set gridfs object on schema and handle special field for gridfs file data GridFS support Apr 24, 2015
@nelhage
Copy link
Contributor

nelhage commented Apr 27, 2015

Thanks for this! I'd love to have at least some basic tests, though – is there anyone else on your team who might be able to help you out? I might be able to find some time to point you in the right direction, if not.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants