This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Example of carbon / patternfly view switching #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move all webpack dependencies and babel to devDependencies * upgrade all webpack dependencies to latest version * switch to webpack serve * switch to css-mimimizer-webpack-plugin from optimize-css-assets-webpack-plugin as suggested by optimize-css-assets-webpack-plugin maintainers Signed-off-by: Pete Muir <[email protected]> Signed-off-by: Davide Bizzarri <[email protected]>
* fix storybook build with webpack5 Signed-off-by: Davide Bizzarri <[email protected]>
Upgrade to webpack 5
Signed-off-by: Pete Muir <[email protected]>
Feat: add module federation
Signed-off-by: Pete Muir <[email protected]>
fix: export the components better
Signed-off-by: Donald Labaj [email protected]
PR ReportBundle SizesView bundle sizes for 'client'
Overall bundle size change: -99.39%View bundle sizes for 'server'
Overall bundle size change: -34.82%Test CoverageView test coverage
Triggered by commit: a4c0f81 |
nictownsend
suggested changes
Dec 3, 2020
| @@ -15,6 +15,7 @@ const config = { | |||
| moduleNameMapper: { | |||
| ...pathsToModuleNameMapper(compilerOptions.paths, { prefix: '<rootDir>/' }), | |||
| ...jestModuleMapper, | |||
| "\\.(css|less)$": "<rootDir>/../node_modules/@patternfly/react-styles/__mocks__/styleMock.js" | |||
There was a problem hiding this comment.
I thought jestModuleMapper brought in fake file support - will it work if you augment /utils/tooling/aliasHelper.js to include less instead of bringing in styleMock?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to ship carbon as the default view layer. However we do need a way to switch between the patternfly view. We should add an example implementation of this to the client.
Fixes issue #127