This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
feat: add graphql cli #131
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| schema: https://raw.githubusercontent.com/rkpattnaik780/enmasse/14c4e82a0c13370d5e14a74669982e1a1105a0ba/console/console-init/ui/mock-console-server/schema.graphql | ||
|
|
||
| extensions: | ||
| codegen: | ||
| generates: | ||
| ./generated/entityModelConstants.ts: | ||
| plugins: | ||
| - typescript | ||
| - typescript-react-apollo | ||
|
There was a problem hiding this comment. some extra flags might be needed. HOC vs Hooks etc. |
||
| config: | ||
| skipTypeNameForRoot: true | ||
| skipTypename: true | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have actual schema available somewhere? This looks like enmasse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed - worth getting one into https://github.com/strimzi/strimzi-admin as a part of this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This schema can then be used/referenced in our MockApi too (in effect completing #50 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, This is
enmasseschema. I suggested it for testing purpose. Later we can point out the actual schema.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matthew-chirgwin Do you have some barebones of the schema. Can I take look on it.
Little bit context. I'm involved in GraphQL spec and working on couple other standards like https://graphql-crud.org
We working on internal company standards for GraphQL schema and being involved in the process for creating schema for strimzi UI will be helpful..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in replying @wtrocki - we have a very barebones/placeholder schema here:
strimzi-ui/server/mockapi/data.ts
Line 7 in e449946
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wtrocki I am looking at defining the schema and would be interested in chatting to you about standards around things like identity, paging, etc. Shall I start a conversation in the strimzi-ui-dev slack channel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Feel free to ping me anywhere.
As for standards we have been using (and promoting) https://graphqlcrud.org
This comes with generators to reduce boilerplate etc. I have been demoing this already to some folks using
https://github.com/wtrocki/strimzi-experiments
See model.graphql as input and finalSchema which is the output. There is numerous benefits of using that format I can chat about