Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for stopping inprogress execution when renew annotation applied #10805

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Add tests for stopping inprogress execution when renew annotation applied #10805

merged 1 commit into from
Nov 13, 2024

Conversation

tinaselenge
Copy link
Contributor

Type of change

Select the type of your PR

  • Refactoring

Description

We don't currently test the flow of applying refresh annotation while KafkaRebalance in "Rebalancing" state.

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@tinaselenge tinaselenge marked this pull request as ready for review November 5, 2024 15:13
@ppatierno ppatierno added this to the 0.45.0 milestone Nov 11, 2024
ppatierno
ppatierno approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ppatierno ppatierno requested a review from a team November 11, 2024 08:20
katheris
katheris approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppatierno ppatierno merged commit 057ea78 into strimzi:main Nov 13, 2024
13 checks passed
@tinaselenge tinaselenge deleted the add-cc-tests branch November 13, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShubhamRwt ShubhamRwt ShubhamRwt approved these changes

@katheris katheris katheris approved these changes

@ppatierno ppatierno ppatierno approved these changes

@scholzj scholzj scholzj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.45.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tinaselenge @scholzj @ppatierno @katheris @ShubhamRwt