Apply metric filtering when adding and removing metrics instead of in the collect method #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen <[email protected]>
Signed-off-by: Owen <[email protected]>
OwenCorrigan76
deleted the
KafkaPrometheusMetricsReporter_performance_improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thie PR adds applying the filtering when adding/removing metrics in KafkaPrometheusMetricsReporter instead of doing it in KafkaMetricsCollector.collect() which runs when the /metrics endpoint is hit so it's on the hot path. It refers to the following issue: #9