Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Strimzi pom.xml file with the usual plugins, checkstyle, etc. #10

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Feb 5, 2024

This PR adds the usual Strimzi pom.xml file with the plugins we use in all other projects. This includes the quality check plugins such as checkstyle or spotbugs as well as the Javadoc or Source plugins to be able to publish the project to Maven. It also fixes the Checkstyle warnings. Separate issues will be opened for the Javadoc issues and Spotbug issues.

@scholzj scholzj added this to the 0.1.0 milestone Feb 5, 2024
@scholzj scholzj requested a review from mimaison February 5, 2024 20:18
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
Copy link
Contributor

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@scholzj scholzj merged commit 9b8756d into strimzi:main Feb 6, 2024
4 checks passed
@scholzj scholzj deleted the add-usual-strimzi-pom-file branch February 6, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants