Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential performance improvements in KafkaPrometheusMetricsReporter #9

Closed
mimaison opened this issue Feb 5, 2024 · 1 comment
Closed

Potential performance improvements in KafkaPrometheusMetricsReporter #9

mimaison opened this issue Feb 5, 2024 · 1 comment
Assignees
@OwenCorrigan76

Comments

@mimaison
Copy link
Contributor

mimaison commented Feb 5, 2024 •
edited
Loading

We could apply the filtering when adding/removing metrics in KafkaPrometheusMetricsReporter instead of doing it in KafkaMetricsCollector.collect() which runs when the /metrics endpoint is hit so it's on the hot path.
@mimaison mimaison changed the title Potential performance improvements Potential performance improvements in KafkaPrometheusMetricsReporter Jun 25, 2024
@mimaison mimaison mentioned this issue Jun 25, 2024
Closed
@OwenCorrigan76 OwenCorrigan76 mentioned this issue Aug 7, 2024
Closed
@OwenCorrigan76 OwenCorrigan76 self-assigned this Aug 7, 2024
@OwenCorrigan76 OwenCorrigan76 mentioned this issue Aug 13, 2024
Merged
@mimaison
Copy link
Contributor Author

Done in #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OwenCorrigan76 OwenCorrigan76

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mimaison @OwenCorrigan76