Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deprecate DataPointer in favor of Span #2421

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Aug 27, 2024

PR Details

DataPointer are just the more rigid and error prone version of what Span provides, marked that type as deprecated, created new signatures providing support for spans instead and moved over the engine calls to that one instead.

One thing I tried to tackle is replacing T[] with Span<T> to reduce the ridiculous amount of signatures Buffer and its variants already hosts, but arrays do not implicitly convert to spans when the function they are passed into is generic. Replacing all cases of T[] with Span<T> would fail to find the method. We'll have to mark those methods as obsolete as well if we want to clean that up.

Related Issue

None

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren merged commit 4464ccb into stride3d:master Nov 10, 2024
6 checks passed
@Eideren Eideren deleted the deprecate_datapointer branch November 10, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant