feat: Deprecate DataPointer in favor of Span #2421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
DataPointer are just the more rigid and error prone version of what Span provides, marked that type as deprecated, created new signatures providing support for spans instead and moved over the engine calls to that one instead.
One thing I tried to tackle is replacing
T[]
withSpan<T>
to reduce the ridiculous amount of signatures Buffer and its variants already hosts, but arrays do not implicitly convert to spans when the function they are passed into is generic. Replacing all cases ofT[]
withSpan<T>
would fail to find the method. We'll have to mark those methods as obsolete as well if we want to clean that up.Related Issue
None
Types of changes
Checklist