feat: Allow Reset Grid Properties for Layout in UI Editor (#1619) #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ added check to see if possible to reset otherwise disable
|
Thanks a bunch for the PR, this one doesn't look as straightforward so I'll pass it to @Kryptos-FR, hopefully he has time to get back to us |
|
I'll look into it. |
Kryptos-FR
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Initial review of the code with some small remarks. I will need to do a second in-depth review when I have more time.
There might be a better place indeed to put the delegate (maybe implemented as a command). If it's a blocking issue, I'm ok to merge it (once my remarks are resolved) and do the refactoring later (in which case, please create a new issue for tracking it).
sources/editor/Stride.Assets.Presentation/NodePresenters/Updaters/UIAssetNodeUpdater.cs
Outdated
Show resolved
Hide resolved
sources/editor/Stride.Assets.Presentation/NodePresenters/Updaters/UIAssetNodeUpdater.cs
Outdated
Show resolved
Hide resolved
sources/editor/Stride.Assets.Presentation/NodePresenters/Updaters/UIAssetNodeUpdater.cs
Outdated
Show resolved
Hide resolved
sources/editor/Stride.Core.Assets.Editor/Quantum/NodePresenters/AssetVirtualNodePresenter.cs
Outdated
Show resolved
Hide resolved
|
Feedback should be implemented, thanks for reviewing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Allowing UI grid properties to be reset to base value in UI editor. 'Reset to base value' button by right clicking on properties doesn't allow to be reset.
Related Issue
Issue: #1619
Types of changes
Just a note: May need a recommendation on where the custom delegate function goes, for now I kept them in UIAssetNodeUpdater file, it may need to be moved elsewhere. I can remove those TODO comments as needed. Thank you!
Checklist