Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MQTT support #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add MQTT support #67

wants to merge 2 commits into from

Conversation

fl0rp
Copy link
Contributor

@fl0rp fl0rp commented Dec 8, 2019

This re-implements the MQTT publishing feature from strichliste 1.

It uses an MQTT implemetation written purely in PHP, so no additional PHP extensions or server configuration is required!

@schinken
Copy link
Contributor

schinken commented Dec 8, 2019

Wow. Not bad!
I'm going to review this change soon and merge the request.

Nice. thx!

@schinken
Copy link
Contributor

schinken commented Dec 8, 2019

We need another solution for the mqtt configuration values. maybe it's enough to not put them unter strichliste: in the yaml file. Because otherwise you could access user/password etc through the /api/settings endpoint

Configuration keys at the root level can now be prefixed with "_" which will not be available at /api/settings.
The SettingsService handles these keys internally
@fl0rp
Copy link
Contributor Author

fl0rp commented Dec 20, 2019

It wasn't quite so easy, putting mqtt settings outside of the strichliste parameter would have complicated handling inside SettingsService, so i came up with a solution, have a look!

@schinken
Copy link
Contributor

I'm going to re-view this next week. I'm going to solve this "private setting" otherwise. I have an idea for that. Then I'm going to merge my other branch and publish an "how to upgrade" tutorial - because the database layout changed a bit.

@schinken
Copy link
Contributor

schinken commented Mar 3, 2020

Did not forget your issue. I'm going to change how the settings are being loaded first and will make a new major release with my latest changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants