Support exchange properties #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderzc
requested review from
gaoran10,
codelipenghui and
a team
as code owners
|
|
coderzc
force-pushed
the
feature_exchange_properties
branch
from
0dba887
to
848f740
Compare
|
@gaoran10 @codelipenghui PTAL |
gaoran10
reviewed
Aug 10, 2022
| case EXCHANGE: | ||
| map.put(k, ExchangeUtil.covertStringValueAsObject(v, String.class)); | ||
| break; | ||
| case INDEX: |
| @@ -44,11 +44,20 @@ public class InMemoryExchange extends AbstractAmqpExchange { | |||
| private final long currentLedgerId; | |||
| private long currentEntryId; | |||
|
|
|||
| private Map<String, Object> properties; | |||
There was a problem hiding this comment.
Maybe we can add this field in class AbstractAmqpExchange.
There was a problem hiding this comment.
PersistentExchange don't need this field.
| properties.forEach((k, v) -> { | ||
| switch (k) { | ||
| case QUEUES: | ||
| map.put(k, ExchangeUtil.covertStringValueAsObject(v, List.class)); |
There was a problem hiding this comment.
The QUEUES is not a custom property.
| map.put(k, ExchangeUtil.covertStringValueAsObject(v, List.class)); | ||
| break; | ||
| case TYPE: | ||
| case EXCHANGE: |
| CompletableFuture<Topic> topicCompletableFuture = amqpTopicManager.getTopic(topicName, createIfMissing); | ||
|
|
||
| Map<String, String> newProperties = null; | ||
| if (createIfMissing && arguments != null) { |
There was a problem hiding this comment.
Maybe we can serialize declare custom properties to a JSON string, and put it to a specific key.
| @@ -57,7 +68,8 @@ protected ExchangeContainer(AmqpTopicManager amqpTopicManager, PulsarService pul | |||
| public CompletableFuture<AmqpExchange> asyncGetExchange(NamespaceName namespaceName, | |||
| String exchangeName, | |||
| boolean createIfMissing, | |||
| String exchangeType) { | |||
| String exchangeType, | |||
| FieldTable arguments) { | |||
There was a problem hiding this comment.
Could we change this to Map<String, Object>?
gaoran10
force-pushed
the
feature_exchange_properties
branch
from
a5575c5
to
172ecc2
Compare
2. add declare check for durable, autoDelete
…o init PersistentExchange.
gaoran10
approved these changes
Oct 17, 2022
coderzc
commented
Oct 17, 2022
Comment on lines
+105
to
+107
| props.put(DURABLE, "" + durable); | ||
| props.put(AUTO_DELETE, "" + autoDelete); | ||
| props.put(INTERNAL, "" + internal); |
There was a problem hiding this comment.
Suggested change
| props.put(DURABLE, "" + durable); | |
| props.put(AUTO_DELETE, "" + autoDelete); | |
| props.put(INTERNAL, "" + internal); | |
| props.put(DURABLE, Double.toString(durable)); | |
| props.put(AUTO_DELETE, Double.toString(autoDelete)); | |
| props.put(INTERNAL, Double.toString(internal)); |
There was a problem hiding this comment.
Sorry, I'll resolve this in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #631
Motivation
Support exchange properties
Modifications
Save durable, auto-delete to exchange properties.
Add exchange declare check for the durable and auto-delete parameter.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)