The tracing in precompiles/bank/bank.go needs to use `GetEVMAddress…

…OrDefault` otherwise we generate app mistmatches
streamingfast · Jun 13, 2024 · 8418897 · 8418897
1 parent 67bd0af
commit 8418897
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/precompiles/bank/bank.go b/precompiles/bank/bank.go
@@ -250,10 +250,9 @@ func (p Precompile) sendNative(ctx sdk.Context, method *abi.Method, args []inter
 	}
 
 	if hooks := tracers.GetCtxEthTracingHooks(ctx); hooks != nil && hooks.OnBalanceChange != nil && (value.Sign() != 0) {
-		receveirEvmAddr, found := p.evmKeeper.GetEVMAddress(ctx, receiverSeiAddr)
-		if !found {
-			return nil, fmt.Errorf("sei address %s is not associated, this shouldn't happen at this point since SendCoinsAndWei above worked", receiverSeiAddr)
-		}
+		// The SendCoinsAndWei function above works with Sei addresses that haven't been associated here. Hence we cannot
+		// use `GetEVMAddress` and enforce to have a mapping. So we use GetEVMAddressOrDefault to get the EVM address.
+		receveirEvmAddr := p.evmKeeper.GetEVMAddressOrDefault(ctx, receiverSeiAddr)
 
 		tracers.TraceTransferEVMValue(ctx, hooks, p.bankKeeper, senderSeiAddr, caller, receiverSeiAddr, receveirEvmAddr, value)
 	}

diff --git a/precompiles/common/expected_keepers.go b/precompiles/common/expected_keepers.go
@@ -30,6 +30,7 @@ type EVMKeeper interface {
 	GetSeiAddress(sdk.Context, common.Address) (sdk.AccAddress, bool)
 	GetSeiAddressOrDefault(ctx sdk.Context, evmAddress common.Address) sdk.AccAddress // only used for getting precompile Sei addresses
 	GetEVMAddress(sdk.Context, sdk.AccAddress) (common.Address, bool)
+	GetEVMAddressOrDefault(sdk.Context, sdk.AccAddress) common.Address
 	GetCodeHash(sdk.Context, common.Address) common.Hash
 	GetPriorityNormalizer(ctx sdk.Context) sdk.Dec
 	GetBaseDenom(ctx sdk.Context) string