clippy fixes

strawlab · Jun 23, 2023 · 9994dea · 9994dea
1 parent c917435
commit 9994dea
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/src/extrinsics.rs b/src/extrinsics.rs
@@ -415,7 +415,7 @@ mod tests {
                 zero.clone(), zero.clone(), zero.clone(), // at camera center
                 zero.clone(), zero.clone(), one.clone(), // one unit in +Z - exactly in camera direction
                 one.clone(), zero.clone(), zero.clone(), // one unit in +X - right of camera axis
-                zero.clone(), one.clone(), zero.clone(), // one unit in +Y - down from camera axis
+                zero.clone(), one, zero, // one unit in +Y - down from camera axis
             ),
         };
 
@@ -435,7 +435,7 @@ mod tests {
         approx::assert_abs_diff_eq!(
             cam_coords.data,
             camera_actual.data,
-            epsilon = epsilon.clone()
+            epsilon = epsilon
         );
     }
 

diff --git a/src/intrinsics_perspective.rs b/src/intrinsics_perspective.rs
@@ -396,31 +396,31 @@ mod tests {
         );
         assert!(IntrinsicParametersPerspective::from_normalized_3x4_matrix(p_valid).is_ok());
 
-        let mut p = p_valid.clone();
+        let mut p = p_valid;
         p[(2, 2)] = 1.1;
         assert!(IntrinsicParametersPerspective::from_normalized_3x4_matrix(p).is_err());
 
-        let mut p = p_valid.clone();
+        let mut p = p_valid;
         p[(0, 3)] = 1.1;
         assert!(IntrinsicParametersPerspective::from_normalized_3x4_matrix(p).is_err());
 
-        let mut p = p_valid.clone();
+        let mut p = p_valid;
         p[(1, 0)] = 1.1;
         assert!(IntrinsicParametersPerspective::from_normalized_3x4_matrix(p).is_err());
 
-        let mut p = p_valid.clone();
+        let mut p = p_valid;
         p[(1, 3)] = 1.1;
         assert!(IntrinsicParametersPerspective::from_normalized_3x4_matrix(p).is_err());
 
-        let mut p = p_valid.clone();
+        let mut p = p_valid;
         p[(2, 0)] = 1.1;
         assert!(IntrinsicParametersPerspective::from_normalized_3x4_matrix(p).is_err());
 
-        let mut p = p_valid.clone();
+        let mut p = p_valid;
         p[(2, 1)] = 1.1;
         assert!(IntrinsicParametersPerspective::from_normalized_3x4_matrix(p).is_err());
 
-        let mut p = p_valid.clone();
+        let mut p = p_valid;
         p[(2, 2)] = 1.1;
         assert!(IntrinsicParametersPerspective::from_normalized_3x4_matrix(p).is_err());
     }
@@ -458,13 +458,13 @@ mod tests {
 
             // Get camera matrix from this Camera instance and check it.
             let pmat = cam.as_camera_matrix();
-            assert_is_pmat_same(&cam, &pmat);
+            assert_is_pmat_same(cam, &pmat);
 
             // Create a new Camera instance from this matrix and check it.
             let cam2 = Camera::from_perspective_matrix(&pmat).unwrap();
             let pmat2 = cam2.as_camera_matrix();
             assert_is_pmat_same(&cam2, &pmat);
-            assert_is_pmat_same(&cam, &pmat2);
+            assert_is_pmat_same(cam, &pmat2);
         }
     }