Allow altering messages exchanged by roles in test env #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1228 +/- ##
=======================================
Coverage 19.36% 19.36%
=======================================
Files 164 164
Lines 10811 10811
=======================================
Hits 2094 2094
Misses 8717 8717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bencher Report
|
| Branch | 1228/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,083.00 | 📈 view plot | 473.00 | 📈 view plot | 738.00 | 📈 view plot | 3.00 | 📈 view plot | 38.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,208.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,158.00 | 📈 view plot | 37.00 | 📈 view plot | 139.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,281.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,551.00 | 📈 view plot | 18.00 | 📈 view plot | 104.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,628.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,763.00 | 📈 view plot | 40.00 | 📈 view plot | 219.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,460.00 | 📈 view plot | 10,585.00 | 📈 view plot | 15,405.00 | 📈 view plot | 80.00 | 📈 view plot | 333.00 |
| client_sv2_open_channel | 📈 view plot | 4,387.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,157.00 | 📈 view plot | 12.00 | 📈 view plot | 62.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,944.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,329.00 | 📈 view plot | 35.00 | 📈 view plot | 184.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,699.00 | 📈 view plot | 8,027.00 | 📈 view plot | 11,674.00 | 📈 view plot | 77.00 | 📈 view plot | 304.00 |
| client_sv2_setup_connection | 📈 view plot | 4,681.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,276.00 | 📈 view plot | 12.00 | 📈 view plot | 67.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,106.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,666.00 | 📈 view plot | 39.00 | 📈 view plot | 207.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,496.00 | 📈 view plot | 14,855.00 | 📈 view plot | 21,821.00 | 📈 view plot | 96.00 | 📈 view plot | 377.00 |
|
| Branch | 1228/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 44.91 |
| client_sv2_handle_message_mining | 📈 view plot | 73.14 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 14.65 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 267.73 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 592.70 |
| client_sv2_open_channel | 📈 view plot | 147.54 |
| client_sv2_open_channel_serialize | 📈 view plot | 285.45 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 376.01 |
| client_sv2_setup_connection | 📈 view plot | 160.54 |
| client_sv2_setup_connection_serialize | 📈 view plot | 456.92 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 978.28 |
|
| Branch | 1228/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,515.00 | 📈 view plot | 3,772.00 | 📈 view plot | 5,295.00 | 📈 view plot | 7.00 | 📈 view plot | 91.00 |
| get_submit | 📈 view plot | 95,430.00 | 📈 view plot | 59,522.00 | 📈 view plot | 85,510.00 | 📈 view plot | 45.00 | 📈 view plot | 277.00 |
| get_subscribe | 📈 view plot | 8,034.00 | 📈 view plot | 2,848.00 | 📈 view plot | 3,984.00 | 📈 view plot | 12.00 | 📈 view plot | 114.00 |
| serialize_authorize | 📈 view plot | 12,298.00 | 📈 view plot | 5,343.00 | 📈 view plot | 7,458.00 | 📈 view plot | 9.00 | 📈 view plot | 137.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,897.00 | 📈 view plot | 9,920.00 | 📈 view plot | 14,017.00 | 📈 view plot | 34.00 | 📈 view plot | 306.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,435.00 | 📈 view plot | 12,097.00 | 📈 view plot | 17,140.00 | 📈 view plot | 55.00 | 📈 view plot | 372.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,589.00 | 📈 view plot | 73,363.00 | 📈 view plot | 105,189.00 | 📈 view plot | 115.00 | 📈 view plot | 595.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 28,017.00 | 📈 view plot | 9,666.00 | 📈 view plot | 13,677.00 | 📈 view plot | 61.00 | 📈 view plot | 401.00 |
| serialize_deserialize_submit | 📈 view plot | 115,479.00 | 📈 view plot | 68,223.00 | 📈 view plot | 97,934.00 | 📈 view plot | 65.00 | 📈 view plot | 492.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,439.00 | 📈 view plot | 8,225.00 | 📈 view plot | 11,589.00 | 📈 view plot | 39.00 | 📈 view plot | 333.00 |
| serialize_submit | 📈 view plot | 99,827.00 | 📈 view plot | 61,566.00 | 📈 view plot | 88,352.00 | 📈 view plot | 48.00 | 📈 view plot | 321.00 |
| serialize_subscribe | 📈 view plot | 11,375.00 | 📈 view plot | 4,195.00 | 📈 view plot | 5,840.00 | 📈 view plot | 15.00 | 📈 view plot | 156.00 |
Handle scenario when TP responds with `SetupConnectionError` to a pool
Because we dont want to fail here, but rather fail when we assert the messages exchanged between the pool and TP(or others)
jbesraa
force-pushed
the
2024-10-18-allow-sniffer-to-alter-msgs
branch
from
961caa7
to
bf97853
Compare
plebhash
reviewed
Oct 31, 2024
plebhash
reviewed
Oct 31, 2024
plebhash
reviewed
Oct 31, 2024
|
after discussing with @jbesraa on the call today, we will potentially pivot this approach towards adding a new primitive (aside to the |
|
(let's assume this new primitive will be called
this stack is represented as a as discussed in the call, here's a dummy test (pseudocode) that could be used to drive the development of this new primitive, at least from a conceptual perspective the scenario here is:
#[tokio::test]
async fn test_tp_mock_setup_connection_error() {
let mock_tp_addr = common::get_available_address();
let sniffer_addr = common::get_available_address();
let pool_addr = common::get_available_address();
let mock_tp_expected_setup_connection = ...
let mock_tp_response_setup_connection_error = ...
let mock_tp_message_pair = (mock_tp_expected_setup_connection, mock_tp_response_setup_connection_error);
// this is a very simple test where we only have one pair
// but the generic case could have multiple pairs
// the order of each (expected, response) pair within the Vec is also important
let mock_tp_message_pair_vec = vec![mock_tp_message_pair];
let mut mock = common::start_mock(mock_tp_addr, mock_tp_message_pair_vec).await;
let sniffer = common::start_sniffer(sniffer_addr, mock_tp_addr).await;
let pool = common::start_pool(Some(pool_addr), Some(sniffer_addr)).await;
assert_common_message!(&sniffer.next_downstream_message(), SetupConnection);
// this specific assertion is essentially proving that mock_tp is behaving as expected
assert_common_message!(&sniffer.next_upstream_message(), SetupConnectionError);
// here it could be interesting to assert the internal state of pool after receiveing SetupConnectionError
// but essentially this is somewhat outside of the scope of this PR, since we just want to add a new primitive to the IT framework and not necessarily improve testing around the pool role implementation
// if this assertion proves too challenging, it can be left for some future work
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1227