Add JDC/S initializers in integration tests #1226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencher Report
|
| Branch | 1226/merge |
| Testbed | sv1 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| get_authorize | 📈 view plot | 8,515.00 | 📈 view plot | 3,772.00 | 📈 view plot | 5,295.00 | 📈 view plot | 7.00 | 📈 view plot | 91.00 |
| get_submit | 📈 view plot | 95,430.00 | 📈 view plot | 59,522.00 | 📈 view plot | 85,510.00 | 📈 view plot | 45.00 | 📈 view plot | 277.00 |
| get_subscribe | 📈 view plot | 8,034.00 | 📈 view plot | 2,848.00 | 📈 view plot | 3,984.00 | 📈 view plot | 12.00 | 📈 view plot | 114.00 |
| serialize_authorize | 📈 view plot | 12,298.00 | 📈 view plot | 5,343.00 | 📈 view plot | 7,458.00 | 📈 view plot | 9.00 | 📈 view plot | 137.00 |
| serialize_deserialize_authorize | 📈 view plot | 24,897.00 | 📈 view plot | 9,920.00 | 📈 view plot | 14,017.00 | 📈 view plot | 34.00 | 📈 view plot | 306.00 |
| serialize_deserialize_handle_authorize | 📈 view plot | 30,435.00 | 📈 view plot | 12,097.00 | 📈 view plot | 17,140.00 | 📈 view plot | 55.00 | 📈 view plot | 372.00 |
| serialize_deserialize_handle_submit | 📈 view plot | 126,589.00 | 📈 view plot | 73,363.00 | 📈 view plot | 105,189.00 | 📈 view plot | 115.00 | 📈 view plot | 595.00 |
| serialize_deserialize_handle_subscribe | 📈 view plot | 28,017.00 | 📈 view plot | 9,666.00 | 📈 view plot | 13,677.00 | 📈 view plot | 61.00 | 📈 view plot | 401.00 |
| serialize_deserialize_submit | 📈 view plot | 115,479.00 | 📈 view plot | 68,223.00 | 📈 view plot | 97,934.00 | 📈 view plot | 65.00 | 📈 view plot | 492.00 |
| serialize_deserialize_subscribe | 📈 view plot | 23,439.00 | 📈 view plot | 8,225.00 | 📈 view plot | 11,589.00 | 📈 view plot | 39.00 | 📈 view plot | 333.00 |
| serialize_submit | 📈 view plot | 99,827.00 | 📈 view plot | 61,566.00 | 📈 view plot | 88,352.00 | 📈 view plot | 48.00 | 📈 view plot | 321.00 |
| serialize_subscribe | 📈 view plot | 11,375.00 | 📈 view plot | 4,195.00 | 📈 view plot | 5,840.00 | 📈 view plot | 15.00 | 📈 view plot | 156.00 |
|
| Branch | 1226/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Estimated Cycles | estimated cycles | Instructions | instructions | L1 Accesses | accesses | L2 Accesses | accesses | RAM Accesses | accesses |
|---|---|---|---|---|---|---|---|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 2,087.00 | 📈 view plot | 473.00 | 📈 view plot | 737.00 | 📈 view plot | 4.00 | 📈 view plot | 38.00 |
| client_sv2_handle_message_mining | 📈 view plot | 8,204.00 | 📈 view plot | 2,137.00 | 📈 view plot | 3,159.00 | 📈 view plot | 36.00 | 📈 view plot | 139.00 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 6,289.00 | 📈 view plot | 1,750.00 | 📈 view plot | 2,549.00 | 📈 view plot | 20.00 | 📈 view plot | 104.00 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 14,640.00 | 📈 view plot | 4,694.00 | 📈 view plot | 6,760.00 | 📈 view plot | 43.00 | 📈 view plot | 219.00 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 27,472.00 | 📈 view plot | 10,585.00 | 📈 view plot | 15,402.00 | 📈 view plot | 83.00 | 📈 view plot | 333.00 |
| client_sv2_open_channel | 📈 view plot | 4,387.00 | 📈 view plot | 1,461.00 | 📈 view plot | 2,157.00 | 📈 view plot | 12.00 | 📈 view plot | 62.00 |
| client_sv2_open_channel_serialize | 📈 view plot | 13,936.00 | 📈 view plot | 5,064.00 | 📈 view plot | 7,331.00 | 📈 view plot | 33.00 | 📈 view plot | 184.00 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 22,707.00 | 📈 view plot | 8,027.00 | 📈 view plot | 11,672.00 | 📈 view plot | 79.00 | 📈 view plot | 304.00 |
| client_sv2_setup_connection | 📈 view plot | 4,677.00 | 📈 view plot | 1,502.00 | 📈 view plot | 2,277.00 | 📈 view plot | 11.00 | 📈 view plot | 67.00 |
| client_sv2_setup_connection_serialize | 📈 view plot | 16,106.00 | 📈 view plot | 5,963.00 | 📈 view plot | 8,666.00 | 📈 view plot | 39.00 | 📈 view plot | 207.00 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 35,504.00 | 📈 view plot | 14,855.00 | 📈 view plot | 21,819.00 | 📈 view plot | 98.00 | 📈 view plot | 377.00 |
|
| Branch | 1226/merge |
| Testbed | sv2 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| client_sv2_handle_message_common | 📈 view plot | 44.93 |
| client_sv2_handle_message_mining | 📈 view plot | 73.41 |
| client_sv2_mining_message_submit_standard | 📈 view plot | 14.65 |
| client_sv2_mining_message_submit_standard_serialize | 📈 view plot | 263.69 |
| client_sv2_mining_message_submit_standard_serialize_deserialize | 📈 view plot | 1,012.20 |
| client_sv2_open_channel | 📈 view plot | 147.40 |
| client_sv2_open_channel_serialize | 📈 view plot | 295.29 |
| client_sv2_open_channel_serialize_deserialize | 📈 view plot | 485.48 |
| client_sv2_setup_connection | 📈 view plot | 164.91 |
| client_sv2_setup_connection_serialize | 📈 view plot | 474.25 |
| client_sv2_setup_connection_serialize_deserialize | 📈 view plot | 1,092.60 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1226 +/- ##
=======================================
Coverage 19.36% 19.36%
=======================================
Files 164 164
Lines 10811 10811
=======================================
Hits 2094 2094
Misses 8717 8717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
GitGab19
reviewed
Oct 18, 2024
plebhash
reviewed
Oct 25, 2024
Comment on lines
+286
to
+290
| pub async fn start_jdc( | ||
| pool_address: SocketAddr, | ||
| tp_address: SocketAddr, | ||
| jds_address: SocketAddr, | ||
| ) -> SocketAddr { |
plebhash
reviewed
Oct 25, 2024
| jdc_address | ||
| } | ||
|
|
||
| pub async fn start_jds(tp_address: SocketAddr) -> SocketAddr { |
|
I pulled this branch and tried to do some quick experimentation, where my goal was to put a sniffer between JDC and JDS to look into the messages they are exchanging. Here's my test: #[tokio::test]
async fn sniff_jdc_jds() {
let sniffer_addr = common::get_available_address();
let tp_addr = common::get_available_address();
let _jdc_addr = common::get_available_address();
let jds_addr = common::get_available_address();
let pool_addr = common::get_available_address();
let _tp = common::start_template_provider(tp_addr.port()).await;
let _pool = common::start_pool(Some(pool_addr), Some(tp_addr)).await;
let _jds = common::start_jds(tp_addr).await;
let sniffer = common::start_sniffer(sniffer_addr, jds_addr).await;
let _jdc = common::start_jdc(pool_addr, tp_addr, sniffer_addr).await;
let d = sniffer.next_downstream_message();
let u = sniffer.next_upstream_message();
println!("d: {:?}", d);
println!("u: {:?}", u);
}but when I tried to run it, I got a nasty panic... did I make some mistake on the test above, or is there something wrong with the APIs? The log line that really stand out is: which is coming from anyways, here's the full panic logs: |
jbesraa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1223