Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update roles/Cargo.lock #1103

Merged
merged 1 commit into from
Aug 15, 2024
Merged

update roles/Cargo.lock #1103

merged 1 commit into from
Aug 15, 2024

Conversation

plebhash
Copy link
Collaborator

@plebhash plebhash commented Aug 14, 2024 •
edited
Loading

roles/Cargo.lock is out of sync with roles/Cargo.toml

PR #1102 will prevent this from happening again in the future

@plebhash plebhash mentioned this pull request Aug 14, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

🐰Bencher

ReportThu, August 15, 2024 at 19:21:43 UTC
ProjectStratum v2 (SRI)
Branchupdate-roles-lockfile
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client_sv2_handle_message_common✅ (view plot)44.48 (-0.17%)45.24 (98.34%)
client_sv2_handle_message_mining✅ (view plot)72.68 (-0.24%)80.25 (90.57%)
client_sv2_mining_message_submit_standard✅ (view plot)14.63 (-0.12%)14.69 (99.61%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)263.75 (-0.29%)284.14 (92.82%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)578.11 (-2.57%)627.31 (92.16%)
client_sv2_open_channel✅ (view plot)171.86 (+3.53%)173.61 (98.99%)
client_sv2_open_channel_serialize✅ (view plot)275.58 (-2.48%)293.75 (93.81%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)373.82 (-1.17%)422.99 (88.38%)
client_sv2_setup_connection✅ (view plot)162.70 (-0.82%)174.69 (93.14%)
client_sv2_setup_connection_serialize✅ (view plot)484.26 (+2.21%)506.62 (95.59%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)1,033.50 (+6.30%)1,042.01 (99.18%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

🐰Bencher

ReportThu, August 15, 2024 at 19:21:48 UTC
ProjectStratum v2 (SRI)
Branch1103/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)		Latency Upper Boundary
nanoseconds (ns) | (%)
client-submit-serialize✅ (view plot)6,504.30 (-5.68%)7,367.52 (88.28%)
client-submit-serialize-deserialize✅ (view plot)7,469.20 (-4.48%)8,329.55 (89.67%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle✅ (view plot)8,029.20 (-4.33%)8,839.44 (90.83%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle✅ (view plot)884.55 (-1.43%)925.51 (95.57%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize✅ (view plot)700.82 (+0.49%)717.75 (97.64%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize✅ (view plot)248.92 (+0.36%)254.93 (97.64%)
client-sv1-get-authorize/client-sv1-get-authorize✅ (view plot)157.60 (+0.27%)162.29 (97.11%)
client-sv1-get-submit✅ (view plot)6,240.50 (-6.29%)7,158.82 (87.17%)
client-sv1-get-subscribe/client-sv1-get-subscribe✅ (view plot)275.03 (-1.12%)290.61 (94.64%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle✅ (view plot)758.09 (+1.35%)777.32 (97.53%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize✅ (view plot)613.48 (-0.25%)638.08 (96.15%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize✅ (view plot)209.98 (+1.60%)219.51 (95.66%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

🐰Bencher

ReportThu, August 15, 2024 at 19:21:47 UTC
ProjectStratum v2 (SRI)
Branchupdate-roles-lockfile
Testbedsv2

🚨 6 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)10,583.00 (+0.36%)10,577.00 (100.06%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)15,395.00 (+0.33%)15,386.76 (100.05%)
client_sv2_open_channel_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)8,019.00 (+0.41%)8,016.56 (100.03%)
client_sv2_open_channel_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)11,669.00 (+0.44%)11,661.18 (100.07%)
client_sv2_setup_connection_serialize_deserializeInstructions (instructions)🚨 (view plot | view alert)14,847.00 (+0.22%)14,844.13 (100.02%)
client_sv2_setup_connection_serialize_deserializeL1 Accesses (accesses)🚨 (view plot | view alert)21,807.00 (+0.24%)21,798.31 (100.04%)

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
client_sv2_handle_message_common✅ (view plot)2,065.00 (+0.64%)2,130.21 (96.94%)✅ (view plot)465.00 (-1.18%)485.97 (95.68%)✅ (view plot)720.00 (-1.60%)754.65 (95.41%)✅ (view plot)10.00 (+40.39%)11.06 (90.39%)✅ (view plot)37.00 (+0.81%)38.63 (95.78%)
client_sv2_handle_message_mining✅ (view plot)8,227.00 (+0.35%)8,335.03 (98.70%)✅ (view plot)2,143.00 (+0.70%)2,171.82 (98.67%)✅ (view plot)3,172.00 (+0.82%)3,217.34 (98.59%)✅ (view plot)31.00 (-18.35%)44.52 (69.63%)✅ (view plot)140.00 (+0.77%)142.03 (98.57%)
client_sv2_mining_message_submit_standard✅ (view plot)6,278.00 (+0.02%)6,388.16 (98.28%)✅ (view plot)1,748.00 (-0.10%)1,763.22 (99.14%)✅ (view plot)2,548.00 (-0.23%)2,575.61 (98.93%)✅ (view plot)18.00 (+2.91%)22.48 (80.09%)✅ (view plot)104.00 (+0.12%)106.90 (97.28%)
client_sv2_mining_message_submit_standard_serialize✅ (view plot)14,763.00 (-0.10%)15,030.26 (98.22%)✅ (view plot)4,692.00 (-0.04%)4,707.22 (99.68%)✅ (view plot)6,748.00 (-0.09%)6,774.82 (99.60%)✅ (view plot)49.00 (+3.37%)52.24 (93.80%)✅ (view plot)222.00 (-0.21%)229.84 (96.59%)
client_sv2_mining_message_submit_standard_serialize_deserialize✅ (view plot)27,545.00 (+0.22%)27,846.46 (98.92%)🚨 (view plot | view alert)10,583.00 (+0.36%)10,577.00 (100.06%)🚨 (view plot | view alert)15,395.00 (+0.33%)15,386.76 (100.05%)✅ (view plot)85.00 (+1.47%)89.26 (95.23%)✅ (view plot)335.00 (+0.03%)345.15 (97.06%)
client_sv2_open_channel✅ (view plot)4,261.00 (-4.84%)4,638.74 (91.86%)✅ (view plot)1,453.00 (-0.48%)1,474.10 (98.57%)✅ (view plot)2,151.00 (-0.09%)2,172.96 (98.99%)✅ (view plot)9.00 (-23.55%)15.32 (58.76%)✅ (view plot)59.00 (-8.86%)68.97 (85.54%)
client_sv2_open_channel_serialize✅ (view plot)14,004.00 (-1.41%)14,462.13 (96.83%)✅ (view plot)5,056.00 (-0.14%)5,077.10 (99.58%)✅ (view plot)7,314.00 (-0.05%)7,338.87 (99.66%)✅ (view plot)36.00 (-3.34%)41.88 (85.97%)✅ (view plot)186.00 (-2.84%)198.90 (93.51%)
client_sv2_open_channel_serialize_deserialize✅ (view plot)22,539.00 (-0.43%)23,011.58 (97.95%)🚨 (view plot | view alert)8,019.00 (+0.41%)8,016.56 (100.03%)🚨 (view plot | view alert)11,669.00 (+0.44%)11,661.18 (100.07%)✅ (view plot)74.00 (+0.88%)81.66 (90.62%)✅ (view plot)300.00 (-1.42%)314.66 (95.34%)
client_sv2_setup_connection✅ (view plot)4,635.00 (-1.29%)4,764.85 (97.27%)✅ (view plot)1,494.00 (-0.46%)1,515.10 (98.61%)✅ (view plot)2,265.00 (-0.50%)2,299.12 (98.52%)✅ (view plot)12.00 (+29.30%)13.90 (86.31%)✅ (view plot)66.00 (-2.64%)69.67 (94.74%)
client_sv2_setup_connection_serialize✅ (view plot)16,092.00 (-1.00%)16,489.60 (97.59%)✅ (view plot)5,955.00 (-0.12%)5,976.10 (99.65%)✅ (view plot)8,647.00 (-0.09%)8,676.99 (99.65%)✅ (view plot)47.00 (+4.85%)49.32 (95.30%)✅ (view plot)206.00 (-2.25%)217.51 (94.71%)
client_sv2_setup_connection_serialize_deserialize✅ (view plot)35,522.00 (-0.04%)35,745.22 (99.38%)🚨 (view plot | view alert)14,847.00 (+0.22%)14,844.13 (100.02%)🚨 (view plot | view alert)21,807.00 (+0.24%)21,798.31 (100.04%)✅ (view plot)97.00 (-2.45%)112.22 (86.44%)✅ (view plot)378.00 (-0.41%)384.46 (98.32%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

🐰Bencher

ReportThu, August 15, 2024 at 19:21:48 UTC
ProjectStratum v2 (SRI)
Branchupdate-roles-lockfile
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)		Estimated Cycles Upper Boundary
estimated cycles | (%)		InstructionsInstructions Results
instructions | (Δ%)		Instructions Upper Boundary
instructions | (%)		L1 AccessesL1 Accesses Results
accesses | (Δ%)		L1 Accesses Upper Boundary
accesses | (%)		L2 AccessesL2 Accesses Results
accesses | (Δ%)		L2 Accesses Upper Boundary
accesses | (%)		RAM AccessesRAM Accesses Results
accesses | (Δ%)		RAM Accesses Upper Boundary
accesses | (%)
get_authorize✅ (view plot)8,508.00 (+0.82%)8,722.07 (97.55%)✅ (view plot)3,746.00 (+0.15%)3,852.72 (97.23%)✅ (view plot)5,248.00 (+0.06%)5,397.77 (97.23%)✅ (view plot)8.00 (+0.43%)10.34 (77.38%)✅ (view plot)92.00 (+2.09%)94.08 (97.79%)
get_submit✅ (view plot)95,473.00 (-0.08%)96,124.20 (99.32%)✅ (view plot)59,439.00 (-0.05%)59,769.82 (99.45%)✅ (view plot)85,353.00 (-0.06%)85,823.99 (99.45%)✅ (view plot)57.00 (+2.99%)62.47 (91.24%)✅ (view plot)281.00 (-0.35%)287.52 (97.73%)
get_subscribe✅ (view plot)7,957.00 (-0.23%)8,262.08 (96.31%)✅ (view plot)2,841.00 (+0.38%)2,937.62 (96.71%)✅ (view plot)3,972.00 (+0.44%)4,096.90 (96.95%)✅ (view plot)13.00 (-18.84%)19.85 (65.49%)✅ (view plot)112.00 (-0.52%)116.81 (95.88%)
serialize_authorize✅ (view plot)12,227.00 (+0.17%)12,495.43 (97.85%)✅ (view plot)5,317.00 (+0.10%)5,423.72 (98.03%)✅ (view plot)7,412.00 (+0.06%)7,561.18 (98.03%)✅ (view plot)11.00 (+1.59%)13.33 (82.51%)✅ (view plot)136.00 (+0.33%)140.09 (97.08%)
serialize_deserialize_authorize✅ (view plot)24,528.00 (+0.23%)24,705.15 (99.28%)✅ (view plot)9,898.00 (-0.02%)10,022.99 (98.75%)✅ (view plot)13,958.00 (-0.06%)14,146.14 (98.67%)✅ (view plot)35.00 (-4.20%)41.41 (84.52%)✅ (view plot)297.00 (+0.70%)297.91 (99.70%)
serialize_deserialize_handle_authorize✅ (view plot)30,283.00 (+0.43%)30,356.80 (99.76%)✅ (view plot)12,101.00 (+0.04%)12,207.72 (99.13%)✅ (view plot)17,113.00 (-0.02%)17,275.62 (99.06%)✅ (view plot)65.00 (+9.72%)66.04 (98.43%)✅ (view plot)367.00 (+0.81%)367.50 (99.86%)
serialize_deserialize_handle_submit✅ (view plot)126,290.00 (-0.09%)127,012.02 (99.43%)✅ (view plot)73,224.00 (-0.03%)73,610.22 (99.48%)✅ (view plot)104,945.00 (-0.04%)105,497.55 (99.48%)✅ (view plot)125.00 (+3.44%)131.65 (94.95%)✅ (view plot)592.00 (-0.45%)599.13 (98.81%)
serialize_deserialize_handle_subscribe✅ (view plot)27,431.00 (-0.08%)27,597.63 (99.40%)✅ (view plot)9,643.00 (+0.11%)9,739.62 (99.01%)✅ (view plot)13,641.00 (+0.13%)13,772.57 (99.04%)✅ (view plot)63.00 (-4.27%)73.57 (85.63%)✅ (view plot)385.00 (-0.19%)388.48 (99.10%)
serialize_deserialize_submit✅ (view plot)114,955.00 (-0.10%)115,635.80 (99.41%)✅ (view plot)68,001.00 (-0.08%)68,392.72 (99.43%)✅ (view plot)97,555.00 (-0.09%)98,135.87 (99.41%)✅ (view plot)71.00 (+1.98%)75.25 (94.36%)✅ (view plot)487.00 (-0.21%)492.21 (98.94%)
serialize_deserialize_subscribe✅ (view plot)22,850.00 (-0.10%)23,103.78 (98.90%)✅ (view plot)8,195.00 (+0.11%)8,295.18 (98.79%)✅ (view plot)11,545.00 (+0.13%)11,679.88 (98.85%)✅ (view plot)35.00 (-10.61%)44.21 (79.17%)✅ (view plot)318.00 (-0.15%)321.39 (98.94%)
serialize_submit✅ (view plot)99,752.00 (-0.13%)100,452.56 (99.30%)✅ (view plot)61,483.00 (-0.05%)61,819.07 (99.46%)✅ (view plot)88,202.00 (-0.05%)88,677.41 (99.46%)✅ (view plot)56.00 (+0.28%)61.98 (90.36%)✅ (view plot)322.00 (-0.77%)329.15 (97.83%)
serialize_subscribe✅ (view plot)11,260.00 (-0.54%)11,597.96 (97.09%)✅ (view plot)4,188.00 (+0.26%)4,284.62 (97.75%)✅ (view plot)5,830.00 (+0.30%)5,956.11 (97.88%)✅ (view plot)15.00 (-7.94%)18.91 (79.32%)✅ (view plot)153.00 (-1.33%)159.68 (95.81%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@Shourya742
Copy link
Contributor

Should we add this to the pre-push hook as well? We already have a PR for that here: #1039.

@plebhash
Copy link
Collaborator Author

plebhash commented Aug 15, 2024 •
edited
Loading

Should we add this to the pre-push hook as well? We already have a PR for that here: #1039.

hmm I think you meant to write this comment on #1102 ?

this PR is simply updating the Cargo.lock file

anyways, just wrote this as a reminder: #1039 (comment)

@Shourya742
Copy link
Contributor

Should we add this to the pre-push hook as well? We already have a PR for that here: #1039.

hmm I think you meant to write this comment on #1102 ?

this PR is simply updating the Cargo.lock file

anyways, just wrote this as a reminder: #1039 (comment)

Silly me...!! thanks

@plebhash plebhash changed the title update roles/Cargo.lock update roles/Cargo.lock + benches/Cargo.lock Aug 15, 2024
@rrybarczyk rrybarczyk linked an issue Aug 15, 2024 that may be closed by this pull request
Cargo.lock files in roles are out of date #1107
Closed
@plebhash plebhash changed the title update roles/Cargo.lock + benches/Cargo.lock update roles/Cargo.lock Aug 15, 2024
@rrybarczyk rrybarczyk merged commit da6023d into stratum-mining:dev Aug 15, 2024
33 checks passed
@plebhash plebhash mentioned this pull request Aug 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrybarczyk rrybarczyk rrybarczyk approved these changes

Assignees

@plebhash plebhash

Labels
ci/cd CI/CD clean-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cargo.lock files in roles are out of date
3 participants
@plebhash @Shourya742 @rrybarczyk