feat(WebAuthn): formalize storage adapter #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to associate multiple credentials to their account. When performing assertions, all the credentials are sent on the `allowList`. When registering a new credential, existing credentials are sent on the `excludeList`. Updated the example to show all the credentials associated to a user. This change is not backwards compatible.
This patch attempts to formalize the storage interface to make it easier to integrate with existing databases. See issue strangerlabs#27
|
Some questions that remain:
|
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
===========================================
+ Coverage 12.66% 25.13% +12.46%
===========================================
Files 5 5
Lines 387 382 -5
===========================================
+ Hits 49 96 +47
+ Misses 338 286 -52
Continue to review full report at Codecov.
|
|
Is this ever going to get merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch attempts to formalize the storage interface to make it easier
to integrate with existing databases.
See issue #27
Depends on #29