Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wormchain): ibc composability mw testing #77

Merged
merged 5 commits into from
Sep 18, 2024
Merged

chore(wormchain): ibc composability mw testing #77

merged 5 commits into from
Sep 18, 2024

Conversation

joelsmith-2019
Copy link

Closes #26

jtieri
jtieri reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had just a couple comments but otherwise these look good and testing logic seems to make sense to me

wormchain/x/ibc-composability-mw/keeper/genesis_test.go Outdated Show resolved Hide resolved
wormchain/x/ibc-composability-mw/keeper/keeper_test.go Outdated Show resolved Hide resolved
wormchain/x/ibc-composability-mw/types/gateway_payload_test.go Outdated Show resolved Hide resolved
wormchain/x/ibc-composability-mw/types/gateway_payload_test.go Outdated Show resolved Hide resolved
wormchain/x/ibc-composability-mw/types/ibc_hooks_test.go Outdated Show resolved Hide resolved
wormchain/x/ibc-composability-mw/types/ibc_hooks_test.go Outdated Show resolved Hide resolved
wormchain/x/ibc-composability-mw/types/pfm_test.go Outdated Show resolved Hide resolved
@joelsmith-2019 joelsmith-2019 merged commit 49beda5 into joel/wormchain-v0.47.12 Sep 18, 2024
29 of 34 checks passed
@joelsmith-2019 joelsmith-2019 deleted the joel/ibc-composability-mw-testing branch September 18, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtieri jtieri jtieri left review comments

@pharr117 pharr117 Awaiting requested review from pharr117

@nik-suri nik-suri Awaiting requested review from nik-suri nik-suri is a code owner

@johnsaigle johnsaigle Awaiting requested review from johnsaigle johnsaigle is a code owner

@mdulin2 mdulin2 Awaiting requested review from mdulin2 mdulin2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelsmith-2019 @jtieri