Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update storybook to make example work #19

Merged
merged 5 commits into from
Oct 14, 2024
Merged

fix: Update storybook to make example work #19

merged 5 commits into from
Oct 14, 2024

Conversation

strozw
Copy link
Contributor

@strozw strozw commented Sep 11, 2024

Why

The example were broken and pnpm storybook and pnpm test did not work.

Summary

  • Updated storybook-related packages to 8.3.0
  • Fix the path of storybookTest used in example/.storybook/vitest.config.mts to @storybook/experimental-addon-test/vitest-plugin.

Also includes

@valentinpalkovic valentinpalkovic added the skip-release Preserve the current version when merged label Oct 14, 2024
@valentinpalkovic
Copy link
Contributor

Thanks for taking care of this!

@valentinpalkovic valentinpalkovic merged commit 0da5f7b into storybookjs:main Oct 14, 2024
@strozw strozw deleted the fix/example branch October 15, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strozw @valentinpalkovic