-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support flat config #156
base: main
Are you sure you want to change the base?
Conversation
@kazupon seems like the release step can't succeed because for some reason a pnpm lock file is modified, even though I can't really reproduce it locally. Do you have any clue? |
@yannbf I'd better debug it by actually looking at |
@yannbf - I think you were almost there with the Current action failureThe reason the current action is failing is that the Experiment with a fix failureYou did pin the version in As there are two new SolutionsI guess the way forward might be:
(Separately, it may be worth upgrading to pnpm v9 some point in the future) |
Oh wow @tom-fletcher thank you so much for your invaluable assist! It worked wonderfully. @kazupon the canary is ready to test!! |
@yannbf The lint itself is fine, but the type is any, so it would be nice if that could be resolved as well. |
Sorry for only getting back to this now. Great to know!! I asked others to try it out so we can get more confidence of merging this. Do you have any potential solution for the types? |
FWIW [Update: ehh, with the small caveat it's not searching subdirectories] |
}, | ||
{ | ||
name: 'storybook:addon-interactions:stories-rules', | ||
files: ['*.stories.@(ts|tsx|js|jsx|mjs|cjs)', '*.story.@(ts|tsx|js|jsx|mjs|cjs)'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be **/*.sto... ?
I tried out the canary build and it's not working for me. It's not searching recursively?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urgh, yes - just noticed that. Adding the **/
does seem to fix it for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yannbf can you deploy a new canary with a fix for the glob pattern?
@yannbf Re: types, I just took a look at what other plugins in my config are doing. Most just return However, looks like this plugin already relies on |
Was able to remove warnings in canary with everything working perfectly by pinning "@typescript-eslint/utils" dependency on eslint to the one configured in my project using an override in my projects 'package.json'. "devDependencies": {
"eslint": "^9.7.0",
"eslint-plugin-storybook": "^0.9.0--canary.156.ed236ca.0",
},
"overrides": {
"@typescript-eslint/utils": {
"eslint": "$eslint"
}
}, Looks like "@typescript-eslint/utils" has a conflicting peer dependency of eslint@"^8.56.0" |
There's a new major version of "@typescript-eslint/utils" that supports eslint v9 |
|
||
- uses: pnpm/action-setup@v4 | ||
with: | ||
version: 9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove this line, then pnpm/action-setup@v4
will be able to pick up pnpm version from packageManager
field in package.json
Awesome work! Any plans to release this soon? |
@yannbf Could you release a new (canary?) version where the glob pattern issue mentioned above is fixed? ESLint v8 is reaching EOL and will stop being supported in about two weeks. |
Closes: #135
What Changed
This is a branch off of the original PR at #152 incredibly done by @kazupon. Only reason I created a new PR is because the previous one was a fork, and therefore CI checks were not running, neither the canary release.
Original PR text:
I've supported ESLint flat configuration and eslint v9
This PR has compatible for legacy style configuration and compatible eslint API using.
So to maintain compatibility, we provide a preset with the
flat
namespace.flat config example is here:
This implementation is based on
eslint-plugin-vue
, which has several presets to support Vue 3 and Vue 2.docs is here:
https://eslint.vuejs.org/user-guide/#usage
Checklist
Check the ones applicable to your change:
pnpm run update-all
Change Type
Indicate the type of change your pull request is:
maintenance
documentation
patch
minor
major
📦 Published PR as canary version:
0.9.0--canary.156.ed236ca.0
✨ Test out this PR locally via: