This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Add typescript declaration file #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wrote it manually based on the documentation, and tried to emulate the type declarations for existing angular modules like angular-animate. |
|
From my Java development experience, I try to stay away from "I" prefixes for interfaces. Can you change this PR to remove them? Also, what's the use case for this change? Are you developing an Angular 1.x app with TypeScript? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a TypeScript declaration file. TypeScript users will automatically get type information without separately installing types using
typingsornpm. TypeScript suggests bundling types with an npm package.