Better check for replysatisfaction notification sending

stonebuzz · Sep 15, 2023 · 605cd15 · 605cd15
1 parent 94b4208
commit 605cd15
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/TicketSatisfaction.php b/src/TicketSatisfaction.php
@@ -200,9 +200,14 @@ public function post_UpdateItem($history = 1)
         global $CFG_GLPI;
 
         if (!isset($this->input['_disablenotif']) && $CFG_GLPI["use_notifications"]) {
+            // Send notification only if fields related to reply are updated.
+            $answer_updates = array_filter(
+                $this->updates,
+                fn ($field) => in_array($field, ['satisfaction', 'comment'])
+            );
+
             $ticket = new Ticket();
-            // date_answer is always updated even if the comment or rate does not change
-            if (count($this->updates) > 1 && $ticket->getFromDB($this->fields['tickets_id'])) {
+            if (count($answer_updates) > 1 && $ticket->getFromDB($this->fields['tickets_id'])) {
                 NotificationEvent::raiseEvent("replysatisfaction", $ticket);
             }
         }