Rails 5 fixes #227
Open
Rails 5 fixes #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use parentheses around parameters in method definitions
Also, make depentencies clear in .gemspec
Don't explicitly support rails < 4.0. or ruby <2.0
…rity_rebased Don't inspect user; too much sensitve data in log
Support polymorphism
Bugfix implicit joins 4.1
Ensure no read-only records are returned when involving DA scopes.
trim trailing whitespace
Corrected rdoc inline code formatting
Test with rails 4 2
- Added fix for the ActiveRecord::Reflection assocation class issues - Updated text render syntax according to rails 5
ActiveRecord::Reflection issue fix
Fixed failing test case
Update .travis.yml
Added fix for sexp integer type errors
Security issues mean Rails 5.2 point release is now 5.2.1.1 Change the dependencies to be more permissive about Rails versions
Allow Rails 5.2.+
Fixes request_with to use Hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are in the process of migrating to Rails 5 and have done the work to ensure DA continues to work for us.
Would you consider merging this one?