Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use erlang:crc32/1 instead of zlib:crc32/2 #1

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

alphabitserial
Copy link
Contributor

See https://www.erlang.org/docs/26/man/zlib#crc32-2

While using your Gleam library glidicon, I ran into an Erlang warning during build and a crash at runtime. This is my first time working with Erlang code, so I may be missing some nuance here, but it doesn't crash anymore when glidicon calls it!

Copy link
Owner

@stevetoro stevetoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to correct this!

@stevetoro stevetoro merged commit 4b0b3e6 into stevetoro:master Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants