Body: changed the semantics of the getId() method

stephengold · Sep 21, 2024 · 32738df · 32738df
1 parent 599ad01
commit 32738df
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/main/java/com/github/stephengold/joltjni/Body.java b/src/main/java/com/github/stephengold/joltjni/Body.java
@@ -24,7 +24,6 @@ of this software and associated documentation files (the "Software"), to deal
 import com.github.stephengold.joltjni.enumerate.EMotionType;
 import com.github.stephengold.joltjni.readonly.ConstAaBox;
 import com.github.stephengold.joltjni.readonly.ConstBody;
-import com.github.stephengold.joltjni.readonly.ConstBodyId;
 import com.github.stephengold.joltjni.readonly.ConstShape;
 import com.github.stephengold.joltjni.readonly.QuatArg;
 import com.github.stephengold.joltjni.readonly.RVec3Arg;
@@ -460,17 +459,16 @@ public float getFriction() {
     }
 
     /**
-     * Access the body's ID for use with {@code BodyInterface}. The body is
+     * Copy the body's ID for use with {@code BodyInterface}. The body is
      * unaffected.
      *
-     * @return a new immutable JVM object with the pre-existing native object
-     * assigned
+     * @return a new object
      */
     @Override
-    public ConstBodyId getId() {
+    public BodyId getId() {
         long bodyVa = va();
         long bodyIdVa = getId(bodyVa);
-        ConstBodyId result = new BodyId(bodyIdVa, false);
+        BodyId result = new BodyId(bodyIdVa, true);
 
         return result;
     }

diff --git a/src/main/native/glue/b/Body.cpp b/src/main/native/glue/b/Body.cpp
@@ -344,8 +344,10 @@ JNIEXPORT jfloat JNICALL Java_com_github_stephengold_joltjni_Body_getFriction
 JNIEXPORT jlong JNICALL Java_com_github_stephengold_joltjni_Body_getId
   (JNIEnv *, jclass, jlong bodyVa) {
     const Body * const pBody = reinterpret_cast<Body *> (bodyVa);
-    const BodyID &result = pBody->GetID();
-    return reinterpret_cast<jlong> (&result);
+    const BodyID &id = pBody->GetID();
+    BodyId * pResult = new BodyID(id);
+    TRACE_NEW("BodyID", pResult)
+    return reinterpret_cast<jlong> (pResult);
 }
 
 inline static const Vec3 getLinearVelocity(jlong bodyVa) {