fix(Markdown): resolve citations within figure, table and chunk captions #673
Comments
nokome
added a commit
that referenced
this issue
Oct 29, 2020
stencila-ci
added a commit
that referenced
this issue
Oct 29, 2020
# [0.100.0](v0.99.16...v0.100.0) (2020-10-29) ### Bug Fixes * **Cite nodes:** Defere populating content until encoding ([02137d2](02137d2)), closes [#732](#732) [#673](#673) * **HTML:** Encode url around title ([862ce14](862ce14)), closes [#733](#733) * **HTML:** Ensure that CodeChunk ids are encoded ([5ddce03](5ddce03)) * **IPYNB:** Ignore empty code chunks ([d39a16f](d39a16f)), closes [#731](#731) * **IPYNB:** Remove redundant name property when decoding authors ([0a1b4ef](0a1b4ef)) * **Markdown:** Make the first row of tables rowType:header ([54332bc](54332bc)) ### Features * **IPYNB:** Handle id, label and caption on code chunks ([2a387fa](2a387fa))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, in Markdown
Citenodes in figure, table and chunk captions are not being resolved e.g.This is likely because the
decodeCitefunction does not get passed acontextwhen called from withindecodeCodeChunketc. A quick fix would be to pass through the context. But I do wonder if it wouldn't be better to not pass the context around as we are currently doing and instead resolve the cite nodes separately using thetransformfunction after doing the first decoding pass. I suspect that this would reduce the complexity of the code and make it easier to debug issues like this.The text was updated successfully, but these errors were encountered: