Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown & HTML: Resolve the content of Cite nodes #732

Closed
nokome opened this issue Oct 28, 2020 · 2 comments
Closed

Markdown & HTML: Resolve the content of Cite nodes #732

nokome opened this issue Oct 28, 2020 · 2 comments
Assignees
@nokome
Labels
released

Comments

@nokome
Copy link
Member

nokome commented Oct 28, 2020

When encoding to Markdown the content of a Cite node is lost and it is represented instead as '@' + target. When decoding Markdown, the content should be set to null and instead be populated just prior to encoding in another format e.g HTML. This would allow users to set options for such as the content e.g. a superscript v author names at the point of encoding.
@nokome nokome self-assigned this Oct 28, 2020
@nokome
Copy link
Member Author

nokome commented Oct 28, 2020

Should also fix #673

@nokome nokome closed this as completed in 02137d2 Oct 29, 2020
stencila-ci added a commit that referenced this issue Oct 29, 2020
@stencila-ci
chore(release): 0.100.0 [skip ci]
5931aa2 
# [0.100.0](v0.99.16...v0.100.0) (2020-10-29)

### Bug Fixes

* **Cite nodes:** Defere populating content until encoding ([02137d2](02137d2)), closes [#732](#732) [#673](#673)
* **HTML:** Encode url around title ([862ce14](862ce14)), closes [#733](#733)
* **HTML:** Ensure that CodeChunk ids are encoded ([5ddce03](5ddce03))
* **IPYNB:** Ignore empty code chunks ([d39a16f](d39a16f)), closes [#731](#731)
* **IPYNB:** Remove redundant name property when decoding authors ([0a1b4ef](0a1b4ef))
* **Markdown:** Make the first row of tables rowType:header ([54332bc](54332bc))

### Features

* **IPYNB:** Handle id, label and caption on code chunks ([2a387fa](2a387fa))
@stencila-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 0.100.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nokome nokome

Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nokome @stencila-ci