Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEP-6: Deprecate /fee endpont #1381

Merged
merged 1 commit into from
Aug 15, 2023
Merged

SEP-6: Deprecate /fee endpont #1381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ecosystem/sep-0006.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Title: Deposit and Withdrawal API
Author: SDF
Status: Active (Interactive components are deprecated in favor of SEP-24)
Created: 2017-10-30
Updated: 2023-01-13
Version 3.18.1
Updated: 2023-08-15
Version 3.19.0
```

## Simple Summary
Expand Down Expand Up @@ -114,7 +114,7 @@ sequenceDiagram
* [`GET /deposit-exchange`](#deposit-exchange): optional
* [`GET /withdraw-exchange`](#withdraw-exchange): optional
* [`GET /info`](#info): required
* [`GET /fee`](#fee): optional
- [`GET /fee`](#fee): **deprecated** optional (only needed for complex fee structures).
* [`GET /transactions`](#transaction-history): required
* [`GET /transaction`](#single-historical-transaction): required

Expand Down Expand Up @@ -1004,6 +1004,8 @@ The default values for the features listed above have been selected based on the

## Fee

**This endpoint is deprecated. The [SEP-38] `GET /price` endpoint should be used to fetch fees instead.**

The fee endpoint allows an anchor to report the fee that would be charged when using the `/deposit` or `/withdraw` endpoints.

This endpoint is important to allow an anchor to accurately report fees to a user even when the fee schedule is complex. If a fee can be fully expressed with the `fee_fixed` and `fee_percent` fields in the `/info` response, then an anchor should not implement this endpoint.
Expand Down Expand Up @@ -1420,6 +1422,7 @@ If the information was malformed, or if the sender tried to update data that isn

## Changelog

* `v3.19.0`: Deprecate `/fee` endpoint
* `v3.18.1`: Fix the missing types of the `withdraw` request parameters and some typo. ([#1365](https://github.com/stellar/stellar-protocol/pull/1365))
* `v3.18.0`: Added `refunded` status and `updated_at` transaction fields to match other SEPs (24, 31) ([#1336](https://github.com/stellar/stellar-protocol/pull/1336))
* `v3.17.1`: Allow anchors to omit the deprecated `X-Stellar-Signature` header ([#1335](https://github.com/stellar/stellar-protocol/pull/1335))
Expand Down
2 changes: 1 addition & 1 deletion ecosystem/sep-0024.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1387,7 +1387,7 @@ There is a small set of changes when upgrading from SEP-6 to SEP-24.
## Changelog

- `v3.3.0`: Add support for [SEP-38] API. Add optional `quote_id` parameter to `post /transactions/deposit/interactive`
and `POST /transactions/deposit/interactive` requests. Add `quote_id` to the transaction object schema.
and `POST /transactions/deposit/interactive` requests. Add `quote_id` to the transaction object schema. Deprecate `/fee` endpoint.
([#1358](https://github.com/stellar/stellar-protocol/pull/1358))
- `v3.2.0`: Deprecate the `wallet_name` and `wallet_url` parameters of `POST /transactions/deposit/interactive` and
`POST /transactions/withdrawal/interactive` requests ([#1364](https://github.com/stellar/stellar-protocol/pull/1364))
Expand Down
Loading