V3 Asset, Avatar, and Profile #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quietbits
commented
Feb 2, 2024
| }; | ||
|
|
||
| /** */ | ||
| export type AssetProps = (SingleAssetProps | MultiAssetProps) & AssetBaseProps; |
There was a problem hiding this comment.
I experimented with using discriminated unions to have a better developer experience when using props that can't be used together. For example, a single asset can't have sourceTwo prop. This makes prop rendering on the website a bit more complicated, but overall it's a better experience when using the component.
|
Preview is available here: |
aristidesstaffieri
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updateRelatedoptional prop in preview to allow updating another prop (also related to discriminated unions).