Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol 22 support: XDR, deprecated API changes, new fields #308

Merged
merged 23 commits into from
Nov 7, 2024
Merged

Protocol 22 support: XDR, deprecated API changes, new fields #308

merged 23 commits into from
Nov 7, 2024

Conversation

2opremio
Copy link
Contributor

@2opremio 2opremio commented Oct 3, 2024

Do not merge (yet)

Shaptic and others added 14 commits July 19, 2024 13:47
@Shaptic
Use TransactionInfo within GetTransactionResponse (#251)
2c74888 
* Encode createdAt as a string for JS support
@Shaptic
Merge branch 'main' into v22-breaking-changes
61fa441
@Shaptic
Merge branch 'main' into v22-breaking-changes
b8a75a0
@2opremio
Merge branch 'main' into v22-breaking-changes
30814ea
@overcat @2opremio
Change API field naming style to Camel Case.
2daf023
@psheth9
Cleanup old retention window and upgrade history-retention-window (#277)
7913265 
* Cleanup old retention-windows and increase history-retention-window to 7 days

* fix tests
@aditya1702
Remove getLedgerEntry (#276)
d055688
@2opremio
Merge branch 'main' into v22-breaking-changes
accd794
@2opremio
Merge branch 'main' into protocol22
100061d
@2opremio
simulate-transaction: remove confusing Cost field in response (#295)
b817750 
* simulate-transaction: remove confusing Cost field in response

* Appease linter
@psheth9
Merge branch 'main' into v22-breaking-changes
38807d3
@psheth9
Remove pagingToken from getEvents (#297)
44db01f
@graydon @Shaptic
@2opremio @overcat @psheth9
Support two sorobans for preflight (#264)
deee37f 

---------

Co-authored-by: George <[email protected]>
Co-authored-by: George <[email protected]>
Co-authored-by: Alfonso Acosta <[email protected]>
Co-authored-by: overcat <[email protected]>
Co-authored-by: Prit Sheth <[email protected]>
@2opremio
Merge pull request #280 from stellar/v22-breaking-changes
e2b6bfe 
Protocol 22 Breaking changes
@Shaptic
Copy link
Contributor

Shaptic commented Oct 3, 2024

Please be sure to not squash merge this so we can keep commit history from the feature branch.

@Shaptic
Copy link
Contributor

Shaptic commented Oct 7, 2024

We should update https://github.com/stellar/stellar-docs/tree/main/docs/data/rpc/api-reference with all of the new endpoints and fields.

@2opremio 2opremio marked this pull request as ready for review October 11, 2024 19:22
@Shaptic Shaptic changed the title Protocol22 Protocol 22 support: XDR, deprecated API changes, new fields Oct 24, 2024
Shaptic and others added 3 commits October 25, 2024 12:37
@Shaptic
Add back in Protocol 22 non-breaking changes for a transition period (#…
5932852 
…317)

* Add both versions of getVersionInfo in
* Make createdAt properly non-breaking
* Revert "Remove pagingToken from getEvents (#297)"

This reverts commit 44db01f.

* Ignore the latest version since it matches the one being used
@Shaptic
Add txHash field to getTransaction after upstream merge (#314)
bb6c594
@2opremio
protocol22: Bump rs-soroban-env to rc3 (#318)
c50a300
@2opremio 2opremio merged commit 7d5c6e5 into main Nov 7, 2024
19 checks passed
@2opremio 2opremio deleted the protocol22 branch November 7, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@2opremio @Shaptic @tamirms @overcat @psheth9 @aditya1702 @graydon