getHealth: add retention window to status #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status will be `"healthy"` when the retention window isn't full and "healthy, retention window full", when the window is full. I am open to design modifications
Shaptic
reviewed
Apr 19, 2024
| oldestLedger := ledgerRange.FirstLedger.Sequence | ||
| rententionWindowFull := (latestLedger - oldestLedger) >= retentionWindow | ||
| if rententionWindowFull { | ||
| status += ", retention window full" |
There was a problem hiding this comment.
Are there a lot of places that do an == "healthy" check? This would break that. Maybe it'd be better to have a separate RetentionWindowStatus: "full" | "incomplete" kinda thing, instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am open to design modifications
What
Status will be
"healthy"when the retention window isn't full and "healthy, retention window full", when the window is full.Why
Make it simpler to write health probes
Known limitations
N/A