Skip to content

Commit

Permalink
Bump integration test references to Core's RC3 image (#322)
Browse files Browse the repository at this point in the history
* Skip rc2 and rc3 in migration tests again
  • Loading branch information
Shaptic authored Nov 4, 2024
1 parent c50a300 commit b1582f3
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/soroban-rpc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ jobs:
SOROBAN_RPC_INTEGRATION_TESTS_CAPTIVE_CORE_BIN: /usr/bin/stellar-core
PROTOCOL_21_CORE_DEBIAN_PKG_VERSION: 22.0.0-2095.rc2.1bccbc921.focal
PROTOCOL_21_CORE_DOCKER_IMG: stellar/stellar-core:22.0.0-2095.rc2.1bccbc921.focal
PROTOCOL_22_CORE_DEBIAN_PKG_VERSION: 22.0.0-2095.rc2.1bccbc921.focal
PROTOCOL_22_CORE_DOCKER_IMG: stellar/stellar-core:22.0.0-2095.rc2.1bccbc921.focal
PROTOCOL_22_CORE_DEBIAN_PKG_VERSION: 22.0.0-2126.rc3.92923c2db.focal
PROTOCOL_22_CORE_DOCKER_IMG: stellar/stellar-core:22.0.0-2126.rc3.92923c2db.focal

steps:
- uses: actions/checkout@v4
Expand Down
5 changes: 2 additions & 3 deletions cmd/soroban-rpc/internal/integrationtest/migrate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,8 @@ func TestMigrate(t *testing.T) {
// This version of RPC wasn't published as a docker container
continue
}
if originVersion == "22.0.0-rc2" {
// This version of RPC can't be upgraded to since that's the one
// set in the soroban_rpc.yml file
if originVersion == "22.0.0-rc2" || originVersion == "22.0.0-rc3" {
// This version of RPC wasn't published as a docker container w/ this tag
continue
}
t.Run(originVersion, func(t *testing.T) {
Expand Down

0 comments on commit b1582f3

Please sign in to comment.