Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.8.0 #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

philipliu
Copy link
Contributor

No description provided.

@@ -12,7 +12,7 @@ val jvmVersion = JavaVersion.VERSION_11

allprojects {
group = "org.stellar.wallet-sdk"
version = "1.7.2"
version = "1.8.0"
Copy link
Contributor

@lijamie98 lijamie98 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be major or patch? I think this can break the application that relies on 0.44.x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to start lining up the release numbers with the typescript-wallet-sdk https://github.com/stellar/typescript-wallet-sdk/releases/tag/v1.8.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't necessarily think we want to align versions with the wallet SDK. We can either make new wallet SDK version 2.0 or 1.8 but I vote for 1.8: we did some small breaking previously in minor versions, and I think it should be fine, given the scope of usage.

Copy link
Contributor

@lijamie98 lijamie98 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it breaks the backward compatibility, we should increment the major version according to semver.

This version bump breaks the compatibility by causing the java-stellar-sdk dependency conflicts.

Copy link
Contributor

@lijamie98 lijamie98 Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ticket ANCHOR-865 is designed to prevent the dependency conflicts.

A PR draft is created: [PR-157]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants